Add Ctrl+click support for file:line:column references in terminal - #2841
Open
RoiSoleil wants to merge 6 commits into
Open
Add Ctrl+click support for file:line:column references in terminal#2841RoiSoleil wants to merge 6 commits into
RoiSoleil wants to merge 6 commits into
Conversation
Member
|
@RoiSoleil : please sign ECA, see https://api.eclipse.org/git/eca/status/gh/eclipse-platform/eclipse.platform/2841 Without this we can't accept contributions. |
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Contributor
Author
It's OK now ;) |
Introduce FileReference record and FileReferenceParser to handle path:line:column references displayed in the terminal (e.g., from 'git grep -n' output). - FileReferenceParser parses hover text into path + optional line/column - OpenFileMouseHandler uses it instead of inline regex parsing - Both classes in view.core.internal (x-internal, no new public API) - 25 unit tests cover plain paths, :line, :line:col, Windows paths, edge cases (zero values, URLs, timestamps, Maven coordinates)
- Strip trailing colon from path when no line/col suffix matches - Fix column offset: 1-based input -> 0-based document (col - 1) - Rename parser patterns for clarity - Make test classes/methods public - Add test for plain path ending with colon - Update time-like test: 12:30:45 parsed as path=12, line=30, col=45
- Remove <p> around <ul> list in FileReferenceParser (invalid HTML that failed javadoc doclint with 'unexpected end tag: </p>') - Use HTML entity ≥ instead of raw Unicode char - Add main descriptions to FileReference.hasLine/hasColumn
RoiSoleil
force-pushed
the
add-file-line-column-support
branch
from
July 31, 2026 15:49
feffc6a to
c303989
Compare
FileReference and FileReferenceParser live in the x-internal package org.eclipse.terminal.view.core.internal. Referencing them from view.ui and the test bundle produces 'access restriction' compiler warnings (6 new issues in CI). Add @SuppressWarnings("restriction") at class level, matching the existing pattern used for OpenResourceDialog.
- Remove redundant @SuppressWarnings('restriction') on mouseUp, now covered by the class-level annotation - Remove @SuppressWarnings('restriction') from test classes: the test bundle sets discouragedReference=ignore, so no access-restriction warnings are produced; the annotation only generated an 'unused compiler option' info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Ctrl+click on file references with line and column numbers (e.g.,
path:42orpath:42:7) in the terminal, commonly produced bygit grep -n.Changes
C:\handled correctly)FileReferenceParserinstead of inline:\splitting and lenient regex(\\d*)(:(\\d*))?.*:line,:line:col, git grep output, Windows paths, URLs, timestamps, Maven coords, zero valuesTesting
Build with:
mvn clean verify -Pbuild-individual-bundles -pl terminal/bundles/org.eclipse.terminal.view.core,terminal/bundles/org.eclipse.terminal.view.ui,terminal/tests/org.eclipse.terminal.test -amCloses #...